No type inferrence of callback arguments inside a tuple union type

[nenikitov]

🔎 Search Terms

• discriminated union inference
• union argument inference

🕗 Version & Regression Information

• This is a compilation error in tsserver 3.3.2

⏯ Playground Link

https://www.typescriptlang.org/play?#code/C4TwDgpgBAkgdgMwgJwILIOZQLwCgpQA+UA2gIwA0UAFAIYBcUcArgLYBGKAlDgHxQA3APYBLACYBdfEVIAmKtXaMAzsGQi4GHtn7DxEgNy4AxkLiqotTI3hI0mHKUo1a2-gG8oAX0O4gA

💻 Code

type InferArg =
  | [1, (a: number) => void]
  | [2, (b: string) => void];
const arg: InferArg = [1, (a) => { }];

🙁 Actual behavior

I get a compilation error:

Parameter 'a' implicitly has an 'any' type.(7006)

🙂 Expected behavior

a should be inferred to be a number because I already passed 1 as the first tuple element. Type inference should be identical to this code:

type InferArg = [1, (a: number) => void];
const arg: InferArg = [1, (a) => { }];

Additional information about the issue

No response

[jcalz]

I think this is one of the issues that prevents #42987 from working. (discriminated unions of tuples don't seem to get contextual typing the way discriminated unions of non-tuple objects do)

[Andarist]

I had this for a while on my wishlist already - might give it a try soon-ish.

The problem stems from the fact that getApparentTypeOfContextualType doesn't do anything with array literal expressions:
https://github.com/microsoft/TypeScript/blob/3f17500cbf0adcdae388a6d161002ab73971f3bf/src/compiler/checker.ts#L29990-L29992

This particular case maybe would just work if we'd call discriminateContextualTypeByObjectMembers (arrays are objects, right? 😉 ) but I think that this requires a special function for the array case. Special consideration has to be made for rest elements (maybe some of the logic could be modeled based on getContextualTypeForElementExpression and changes like this one). On top of that, .length should be ignored completely by it when looking for completions since the array literal might still be "incomplete" - so the completions should only care about what has already been typed in and assume that more things might still be typed in.

[nenikitov]

Thank you for the explanation

[fwolff]

I think I have a fix for this issue: fwolff@9eecc30. It works with the code snippet given by @nenikitov, the type of the parameter a is correctly inferred to number.

The change is minimal and inspired by what @Andarist suggested in his comment. Before going further, I'd like to get some feedback from @jcalz (I have been discussing tuple issues with him here and on stackoverflow) or anybody having worked on similar topics.

[fwolff]

See my PR: #60434.