Skip to content

Type guard variables do not get narrowed within class bodies #5619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
weswigham opened this issue Nov 11, 2015 · 0 comments
Closed

Type guard variables do not get narrowed within class bodies #5619

weswigham opened this issue Nov 11, 2015 · 0 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@weswigham
Copy link
Member

For example:

let x: string | number;

if (typeof x === "string") {

    let n = class {
        constructor() {
            x; // Should be "string" but is "string | number".
        }
    }
}
@DanielRosenwasser DanielRosenwasser added the Bug A bug in TypeScript label Nov 11, 2015
@mhegazy mhegazy added this to the TypeScript 1.8 milestone Nov 11, 2015
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Nov 19, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

3 participants