Skip to content

Remove unused exports & dead code (using Knip) #56818

Closed
@webpro

Description

@webpro

Acknowledgement

  • I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion.

Comment

Opened a PR (#56817) to clean up some code using Knip.

The removed bits look fairly harmless and safe to merge from my untrained eye. Yet the question is also: should Knip be removed from the PR, or added to the devDependencies and some CI job to make sure regression won't creep in later down the road?

I'll do my part by improving Knip itself and adding it to Knip's integration tests as to not cause you more trouble later.

Thanks a lot for being such a stable source file parser (and so much more), this is a small PR to give something back :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    In DiscussionNot yet reached consensusInfrastructureIssue relates to TypeScript team infrastructure

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions