Skip to content

Refactoring 'Move to file' imports undefined from source file #60783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aramikuto opened this issue Dec 17, 2024 Β· 1 comment Β· Fixed by #61084
Closed

Refactoring 'Move to file' imports undefined from source file #60783

aramikuto opened this issue Dec 17, 2024 Β· 1 comment Β· Fixed by #61084
Assignees
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue

Comments

@aramikuto
Copy link

πŸ”Ž Search Terms

"move to file imports undefined", "refactor", "move to a new file imports undefined"

πŸ•— Version & Regression Information

This changed between versions 5.7.1-rc and 5.7.2

⏯ Playground Link

https://www.typescriptlang.org/play/?#code/KYDwDg9gTgLgBAYwgOwM7wG4EMoEssBGANsHALxwCuyAJsAGa7LA0DcQA

πŸ’» Code

export const variable = undefined;

πŸ™ Actual behavior

When applying the Move to file or Move to a new file refactoring, the resulting file incorrectly imports an undefined value from the original module.

For example, if the original file is named orig.ts, the refactored file will output

import { undefined } from "./orig";

export const variable = undefined;

πŸ™‚ Expected behavior

undefined is an internal type and should not be imported. The correct output should be:

export const variable = undefined;

Additional information about the issue

No response

@aramikuto
Copy link
Author

I performed a bisect, and it seems that this issue was most likely introduced in #60450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants