Skip to content

[tsserver] Support for "definitions" command (several definition) #7905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
angelozerr opened this issue Apr 6, 2016 · 1 comment
Closed
Labels
API Relates to the public API for TypeScript Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Suggestion An idea for TypeScript

Comments

@angelozerr
Copy link

Take a sample:

import {IFoldingRange} from 'vs/editor/contrib/folding/common/foldingRange';

export function computeRanges(): IFoldingRange[]

I would like when I do a Ctrl+Click on the last IFoldingRange that IDE provides 2 definitions:

  • a definition with import {} (like today). Here Ctrl+Click on IFoldingRange[] select {IFoldingRange}
  • a definition where IFoldingRange is exported. Here Ctrl+Click on IFoldingRange[] open "vs/editor/contrib/folding/common/foldingRange" file and select where IFoldingRange is exported.

So it should be cool if tsserver could provide "definitions" command to return this array of definition.

@DanielRosenwasser DanielRosenwasser added Suggestion An idea for TypeScript API Relates to the public API for TypeScript labels Apr 7, 2016
@RyanCavanaugh RyanCavanaugh added the Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature label Aug 13, 2018
@RyanCavanaugh
Copy link
Member

We now skip through imports and that seems to be broadly preferred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Relates to the public API for TypeScript Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

3 participants