Typescript@next and npm linked node_modules

[pocesar]

I'm this problem on windows 10. I have a linked node_module that was created using npm link @pocesar/moip2, Typescript@next is trying to use the typings in the linked node_modules\@types\bluebird\index.d.ts

TypeScript Version: nightly

The tsc --listFiles shows:

../node-moip2/node_modules/@types/bluebird/index.d.ts(759,5): error TS2300: Duplicate identifier 'export='.

g:/www/neuro/node_modules/typescript/lib/lib.d.ts
g:/www/neuro/node_modules/@types/node/index.d.ts
g:/www/neuro/node_modules/@types/express-serve-static-core/index.d.ts
g:/www/neuro/node_modules/@types/mime/index.d.ts
g:/www/neuro/node_modules/@types/serve-static/index.d.ts
g:/www/neuro/node_modules/@types/express/index.d.ts
g:/www/neuro/node_modules/@types/body-parser/index.d.ts
g:/www/neuro/node_modules/@types/lodash/index.d.ts
g:/www/neuro/node_modules/@types/lru-cache/index.d.ts
g:/www/neuro/node_modules/@types/bluebird/index.d.ts
g:/www/neuro/src/server/modules/correios.ts
g:/www/node-moip2/node_modules/@types/bluebird/index.d.ts
g:/www/node-moip2/moip.d.ts

My local tsconfig.json is:

{
    "compilerOptions": {
        "module": "commonjs",
        "noImplicitAny": true,
        "removeComments": false,
        "preserveConstEnums": true,
        "inlineSourceMap": true,
        "outDir": "lib",
        "noImplicitReturns": true,
        "noImplicitUseStrict": true,
        "noImplicitThis": true,
        "noUnusedLocals": true,
        "allowSyntheticDefaultImports": false,
        "allowUnusedLabels": false,
        "allowUnreachableCode": false,
        "noUnusedParameters": true,
        "pretty": true,
        "newLine": "LF",
        "allowJs": false,
        "moduleResolution": "node",
        "target": "es5",
        "declaration": false
    },
    "rootDir": "src/server",
    "exclude": [
        "lib",
        "src/user",
        "src/client",
        "src/buy",
        "src/admin",
        "data",
        "config",
        ".vscode",
        ".tscache",
        "node_modules",
        "tests",
        "conf",
        "keys",
        ".sass-cache",
        "views",
        "public"
    ]
}

The tsconfig.json in moip2:

{
    "compilerOptions": {
        "module": "commonjs",
        "noImplicitAny": true,
        "removeComments": false,
        "preserveConstEnums": true,
        "sourceMap": false,
        "outDir": ".",
        "moduleResolution": "node",
        "target": "es2015",
        "declaration": true
    },
    "files": [
        "moip.ts"
    ]
}

Do I need to use excludes? Doesn't files and excludes cancel each other?

Expected behavior:

Should ignore the node_modules on linked packages as well

Actual behavior:

The exclude option is being ignored for npm link'd packages

[mhegazy]

looks like we need to get real path when enumerating the types directories.

[timjroberts]

This is also an issue on OSX. The @types folders from within the linked libraries are included when compiling the top-level package:

node_modules/@types/react/index.d.ts(7,21): error TS2300: Duplicate identifier 'React'.
../my-library/node_modules/@types/react/index.d.ts(7,21): error TS2300: Duplicate identifier 'React'.

I use my own gulp-npmworkspace to manage large projects and this is a show-stopper for me. Currently, the only workaround is to use physical paths in the package.json and call npm install every time you make a change.

[RyanCavanaugh]

Same root cause as #9771; the path machinery as it stands is fine as long as we don't freak out over importing two files with the same UMD global

[Pajn]

Hmm, I'm not so sure the path machinery is fine actually.With this tsconfig.json

{
  "compilerOptions": {
    "jsx": "preserve",
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "target": "es2015",
    "module": "es2015",
    "moduleResolution": "node",
    "outDir": ".tmp",
    "allowJs": true,
    "rootDir": "."
  },
  "exclude": [
    "node_modules",
    "gulpfile.js"
  ]
}

I get these errors

error TS6059: File '/home/rasmus/Development/beanloop/shujin/node_modules/winston/lib/winston.js' is not under 'rootDir' '/home/rasmus/Development/beanloop/socialview/data'. 'rootDir' is expected to contain all source files.
error TS6059: File '/home/rasmus/Development/beanloop/shujin/node_modules/winston/lib/winston/common.js' is not under 'rootDir' '/home/rasmus/Development/beanloop/socialview/data'. 'rootDir' is expected to contain all source files.
error TS6059: File '/home/rasmus/Development/beanloop/shujin/node_modules/winston/lib/winston/config.js' is not under 'rootDir' '/home/rasmus/Development/beanloop/socialview/data'. 'rootDir' is expected to contain all source files.
error TS6059: File '/home/rasmus/Development/beanloop/shujin/node_modules/winston/lib/winston/config/cli-config.js' is not under 'rootDir' '/home/rasmus/Development/beanloop/socialview/data'. 'rootDir' is expected to contain all source files.
error TS6059: File '/home/rasmus/Development/beanloop/shujin/node_modules/winston/lib/winston/config/npm-config.js' is not under 'rootDir' '/home/rasmus/Development/beanloop/socialview/data'. 'rootDir' is expected to contain all source files.
error TS6059: File '/home/rasmus/Development/beanloop/shujin/node_modules/winston/lib/winston/config/syslog-config.js' is not under 'rootDir' '/home/rasmus/Development/beanloop/socialview/data'. 'rootDir' is expected to contain all source files.
error TS6059: File '/home/rasmus/Development/beanloop/shujin/node_modules/winston/lib/winston/container.js' is not under 'rootDir' '/home/rasmus/Development/beanloop/socialview/data'. 'rootDir' is expected to contain all source files.
error TS6059: File '/home/rasmus/Development/beanloop/shujin/node_modules/winston/lib/winston/exception.js' is not under 'rootDir' '/home/rasmus/Development/beanloop/socialview/data'. 'rootDir' is expected to contain all source files.
error TS6059: File '/home/rasmus/Development/beanloop/shujin/node_modules/winston/lib/winston/logger.js' is not under 'rootDir' '/home/rasmus/Development/beanloop/socialview/data'. 'rootDir' is expected to contain all source files.
error TS6059: File '/home/rasmus/Development/beanloop/shujin/node_modules/winston/lib/winston/transports.js' is not under 'rootDir' '/home/rasmus/Development/beanloop/socialview/data'. 'rootDir' is expected to contain all source files.
error TS6059: File '/home/rasmus/Development/beanloop/shujin/node_modules/winston/lib/winston/transports/transport.js' is not under 'rootDir' '/home/rasmus/Development/beanloop/socialview/data'. 'rootDir' is expected to contain all source files.

shujin is an npm linked dependency and for some reason typescript uses its modules even though node_modules is excluded.

Should I open a new issue?

[pocesar]

I'm still getting this problem with a node_module that has been linked to the project and has a @types. it's breaking "typings" from my typings directory (bunch of duplicate exports)

[timjroberts]

I think this is going to be fixed in 2.0.1, but that hasn't been released yet?

[pocesar]

I'm using typescript@next (aka 2.1.0)

[timjroberts]

You're right @pocesar, I can't get it working either. I'm switching back to using DefinitelyTyped directly. No matter how I try to organise my packages, it doesn't work when I have a dependency symlinked. It still brings in the shared @types/xxx from the dependency and I get the duplicates.

[jasonswearingen]

This bug still exists on tsc version 2.0.3. it should be reopened.