Skip to content

Revert "fix #11670, support type guards in NumberConstructor (#11722)" #12317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2016
Merged

Revert "fix #11670, support type guards in NumberConstructor (#11722)" #12317

merged 1 commit into from
Nov 17, 2016

Conversation

RyanCavanaugh
Copy link
Member

Fixes #12302

This reverts commit 4fbbbed.

@mhegazy
Copy link
Contributor

mhegazy commented Nov 17, 2016

why the other 3? it is just isNaN that is wrong

@HerringtonDarkholme
Copy link
Contributor

@mhegazy if a number is not infinite, it still can be a number. The logic applies to other three. We just forget to check the falsy path when introducing the type guard .

@RyanCavanaugh RyanCavanaugh merged commit c90a40c into microsoft:master Nov 17, 2016
@RyanCavanaugh RyanCavanaugh deleted the fix12302 branch November 17, 2016 19:17
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhegazy mhegazy mhegazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RyanCavanaugh @mhegazy @HerringtonDarkholme @msftclas