-
Notifications
You must be signed in to change notification settings - Fork 12.9k
elaborate check before converting fresh literal type to regular #12595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
tests/cases/compiler/nestedFreshLiteral.ts(12,21): error TS2322: Type '{ nested: { prop: { colour: string; }; }; }' is not assignable to type 'NestedCSSProps'. | ||
Types of property 'nested' are incompatible. | ||
Type '{ prop: { colour: string; }; }' is not assignable to type 'NestedSelector | undefined'. | ||
Type '{ prop: { colour: string; }; }' is not assignable to type 'NestedSelector'. | ||
Types of property 'prop' are incompatible. | ||
Type '{ colour: string; }' is not assignable to type 'CSSProps'. | ||
Object literal may only specify known properties, and 'colour' does not exist in type 'CSSProps'. | ||
|
||
|
||
==== tests/cases/compiler/nestedFreshLiteral.ts (1 errors) ==== | ||
interface CSSProps { | ||
color?: string | ||
} | ||
interface NestedCSSProps { | ||
nested?: NestedSelector | ||
} | ||
interface NestedSelector { | ||
prop: CSSProps; | ||
} | ||
|
||
let stylen: NestedCSSProps = { | ||
nested: { prop: { colour: 'red' } } | ||
~~~~~~~~~~~~~ | ||
!!! error TS2322: Type '{ nested: { prop: { colour: string; }; }; }' is not assignable to type 'NestedCSSProps'. | ||
!!! error TS2322: Types of property 'nested' are incompatible. | ||
!!! error TS2322: Type '{ prop: { colour: string; }; }' is not assignable to type 'NestedSelector | undefined'. | ||
!!! error TS2322: Type '{ prop: { colour: string; }; }' is not assignable to type 'NestedSelector'. | ||
!!! error TS2322: Types of property 'prop' are incompatible. | ||
!!! error TS2322: Type '{ colour: string; }' is not assignable to type 'CSSProps'. | ||
!!! error TS2322: Object literal may only specify known properties, and 'colour' does not exist in type 'CSSProps'. | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
//// [nestedFreshLiteral.ts] | ||
interface CSSProps { | ||
color?: string | ||
} | ||
interface NestedCSSProps { | ||
nested?: NestedSelector | ||
} | ||
interface NestedSelector { | ||
prop: CSSProps; | ||
} | ||
|
||
let stylen: NestedCSSProps = { | ||
nested: { prop: { colour: 'red' } } | ||
} | ||
|
||
//// [nestedFreshLiteral.js] | ||
var stylen = { | ||
nested: { prop: { colour: 'red' } } | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// @strictNullChecks: true | ||
interface CSSProps { | ||
color?: string | ||
} | ||
interface NestedCSSProps { | ||
nested?: NestedSelector | ||
} | ||
interface NestedSelector { | ||
prop: CSSProps; | ||
} | ||
|
||
let stylen: NestedCSSProps = { | ||
nested: { prop: { colour: 'red' } } | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is not this just
maybeTypeOfKind(type, ~TypeFlags.Nullable)
?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, since AFAIR
maybeTypeOfKind(type, ~TypeFlags.Nullable)
will returntrue
for union or intersection type that consist of non-nullable type and nullable type and this is not what we want.