Spelling code fix: suggestions from apparent type #16844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code fix for spelling correction needs to provide suggestions based on the apparent type since sometimes the type at a location will be a type parameter. One such example is `this`. Fixes #16744
|
Can you add tests for primitives (e.g. function foo<T extends number | string>(x: T) {
return x.toStrang();
} |
|
Turns out suggestions don't work at compile-time on non-object types. That's kind of a separate bug, but simple enough to fix, so I'll just fix it here. |
This provides suggestions for more types based on their apparent type: unions, type parameters with constraints, primitives.
Test spelling suggestions for primitives, unions/intersections and type parameters with constraints.
sandersn
commented
Jun 30, 2017
| @@ -87,7 +87,7 @@ tests/cases/conformance/es6/templates/taggedTemplateStringsWithOverloadResolutio | |||
| function fn5() { return undefined; } | |||
| fn5 `${ (n) => n.toFixed() }`; // will error; 'n' should have type 'string'. | |||
| ~~~~~~~ | |||
| !!! error TS2339: Property 'toFixed' does not exist on type 'string'. | |||
| !!! error TS2551: Property 'toFixed' does not exist on type 'string'. Did you mean 'fixed'? | |||
There was a problem hiding this comment.
this looks weird until you look up fixed and find out that it's actually a deprecated member of String.
yuit
approved these changes
Jun 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code fix for spelling correction needs to provide suggestions based on the apparent type since sometimes the type at a location will be a type parameter. One such example is
this.Fixes #16744