Limit recursive structured type resolution #20400
Conversation
The same way that getResolvedMembersOrExportsOfSymbol does. That functionality may not be needed anymore, in fact.
|
Hm, looks like travis is still down because of the chai failure. |
src/compiler/checker.ts
Outdated
| @@ -6171,6 +6171,8 @@ namespace ts { | |||
|
|
|||
| function resolveStructuredTypeMembers(type: StructuredType): ResolvedType { | |||
| if (!(<ResolvedType>type).members) { | |||
| const earlySymbols = (type.symbol && type.symbol.members) || emptySymbols; | |||
There was a problem hiding this comment.
If type is a generic type, its symbol's members will not be the instantiated ones, they'll be the declared ones, right? That would mean this earlySymbols table will not have an appropriate type mapper applied to it, if one should be available, which could surface in strange stateful behavior that results in type variable leakage.
There was a problem hiding this comment.
I think this recursion-guard-set needs to be handled within each sub-resolve function to account for this correctly. Actually, they mostly distill to flavors of resolveObjectTypeMembers, yes? It should be sufficient to add something like setStructuredTypeMembers(type, members, callSignatures, constructSignatures, stringIndexInfo, numberIndexInfo); to above line 5800, right? That way all the non-inherited members are present and resolving. resolveMappedTypeMembers already has a similar guards. resolveAnonymousTypeMembers may need one, too, since apparently a case exists where an anonymous type can have base classes.
There was a problem hiding this comment.
After much discussion, we got a test of dynamic names to exhibit this failure, or something close. Your suggested fix worked, so that's what I did.
Fixes #20330
Fixes #20772
It sets empty structured type members immediately so that recursive calls to
resolveStructuredTypeMemberswill never proceed.Edit: This change now mimics the behaviour of
getResolvedMembersOrExportsOfSymbolby filling in the symbols of the 'empty' structured with the already-bound members of the type. This makes the dynamic names test pass.