Skip to content

Add method signature handler to getTypeOfVariableOrParameterOrProperty #20825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2017

Conversation

weswigham
Copy link
Member

#20706 Made the declaration kinds handled by getTypeOfVariableOrParameterOrProperty more explicit, but didn't include MethodSignature, which we have no normal tests covering. It being missing caused a DT test to trigger an assertion. There's a good chance this shouldn't be possible in the first place, but I need to open another issue to track that.

@weswigham weswigham merged commit ae21198 into microsoft:master Dec 29, 2017
errendir added a commit to errendir/TypeScript that referenced this pull request Jan 7, 2018
* origin/master: (216 commits)
  Accepted baselines.
  Check whether we have a class before testing whether we have a super-class.
  Added tests.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Add method signature handler to getTypeOfVariableOrParameterOrProperty (microsoft#20825)
  LEGO: check in for master to temporary branch.
  Simplify test and add explanatory assertion
  LEGO: check in for master to temporary branch.
  Add dynamic file open test
  Allow dynamic files script info to be created when not opened by client
  LEGO: check in for master to temporary branch.
  Accept new baselines
  Add regression test
  Fix narrowTypeBySwitchOnDiscriminant function
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Move recursion limiter to individual resolve* functions
  User runner submodule improvements (microsoft#20868)
  Reset partial memberlist on defered circularity to calculate the correct members (microsoft#20179)
  ...
@weswigham weswigham deleted the fix-method-signature-handling branch April 10, 2018 23:11
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants