Skip to content

Fix temp variable emit for names used in nested classes #21206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2018
Merged

Fix temp variable emit for names used in nested classes #21206

merged 1 commit into from
Jan 17, 2018

Conversation

rbuckton
Copy link
Contributor

This change reserves temporary names generated for class expressions that are reused in nested scopes to prevent collisions.

Fixes #20744

@rbuckton rbuckton requested review from weswigham and mhegazy January 16, 2018 20:35
@rbuckton
Copy link
Contributor Author

@mhegazy, @DanielRosenwasser - Does this need to be cherry-picked into release-2.7?

@mhegazy
Copy link
Contributor

mhegazy commented Jan 16, 2018

You do not have to worry about that. I will port master to 2.7 later this week..

@rbuckton rbuckton merged commit cd525fb into master Jan 17, 2018
@rbuckton rbuckton deleted the fix20744 branch January 17, 2018 00:00
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weswigham weswigham weswigham approved these changes

@mhegazy mhegazy Awaiting requested review from mhegazy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbuckton @mhegazy @weswigham