Skip to content

Fix incorrect parenthesization logic for conditional expression branches #21216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2018
Merged

Fix incorrect parenthesization logic for conditional expression branches #21216

merged 1 commit into from
Jan 17, 2018

Conversation

rbuckton
Copy link
Contributor

When determining whether we should parenthesize a conditional branch, we were only looking at the conditional branch node even when it might be wrapped in PartiallyEmittedExpression nodes.

Fixes #19103

@rbuckton rbuckton requested a review from weswigham January 16, 2018 23:18
@rbuckton rbuckton merged commit dcc5c32 into master Jan 17, 2018
@rbuckton rbuckton deleted the fix19103 branch January 17, 2018 01:00
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhegazy mhegazy mhegazy approved these changes

@weswigham weswigham Awaiting requested review from weswigham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbuckton @mhegazy