Allow boolean literals to be generated from contextual types again #21503
+614
−316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Feb 1, 2018
mhegazy
reviewed
Feb 1, 2018
| @@ -15,7 +15,7 @@ var numStrTuple2: [number, string] = [5, "foo", true]; | |||
|
|
|||
| var numStrBoolTuple: [number, string, boolean] = [5, "foo", true]; | |||
| >numStrBoolTuple : [number, string, boolean] | |||
| >[5, "foo", true] : [number, string, boolean] | |||
| >[5, "foo", true] : [number, string, true] | |||
There was a problem hiding this comment.
this was the reason we made this original change... to make the error messages look nicer. but i guess we can not differentiate between true | false and boolean in any meaningful manner.
mhegazy
approved these changes
Feb 1, 2018
|
Please port to release-2.7 as well. |
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
Feb 1, 2018
…icrosoft#21503) * Allow boolean literals to be generated from contextual types again * Update fourslash test
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
Feb 1, 2018
…icrosoft#21503) * Allow boolean literals to be generated from contextual types again * Update fourslash test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the exception for
booleanfrom the checks inisLiteralOfContextualType. This causes us to infer boolean literals in more places (as expected and sometimes necessary), but I don't see any tests broken by this change, so it seems fine.Fixes #21436
Fixes #21427