Don't intern all strings and numbers. Just the ones used as declaration names #2177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // "a['propname']" then we want to store "propname" in the name table. | ||
| if (isDeclarationName(node) || | ||
| node.parent.kind === SyntaxKind.ExternalModuleReference || | ||
| isArgumentOfElementAccessExpression(node)) { |
There was a problem hiding this comment.
Wouldn't you be more curious as to whether the element access is part of the LHS of an assignment?
There was a problem hiding this comment.
No. For example, if you have:
foo(a['propname'])
we simply want to add 'propname' into the name table any time we see this, so we can effectively do 'Find All Refs' on a property called 'propname'.
|
👍 |
CyrusNajmabadi
added a commit
that referenced
this pull request
Mar 2, 2015
Don't intern all strings and numbers. Just the ones used as declaration names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.