Separate isGlobalCompletion from CompletionKind #22074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
mhegazy
reviewed
Feb 21, 2018
| @@ -753,6 +754,7 @@ namespace ts.Completions { | |||
| log("getCompletionData: Is inside comment: " + (timestamp() - start)); | |||
|
|
|||
| let insideJsDocTagTypeExpression = false; | |||
| let isInSnippetScope = false; | |||
There was a problem hiding this comment.
should not this default to true then? it used to default to Global before. we do not want to change the behavior really since we have no test coverage here.
There was a problem hiding this comment.
I think this is correct -- we only assigned completionKind = CompletionKind.Global; in one place before, and that location is now the only assignment to isInSnippetScope.
mhegazy
approved these changes
Feb 21, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequel to #21973 -- since we can have
isGlobalCompletion === falsefor global completions, give it a different nameisInSnippetScopeand make unrelated toCompletionKind.May also fix #21790 due to not returning
needsConvertPropertyAccess: trueonCompletionKind.None.