fix #23589 - stripping internal constructor parameter properties #23615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I haven't signed the CLA yet. I need to get company approval first. |
mhegazy
reviewed
Apr 23, 2018
| @@ -966,6 +966,7 @@ namespace ts { | |||
| const oldDiag = getSymbolAccessibilityDiagnostic; | |||
| parameterProperties = compact(flatMap(ctor.parameters, param => { | |||
| if (!hasModifier(param, ModifierFlags.ParameterPropertyModifier)) return; | |||
| if (shouldStripInternalParameterProperty(param)) return; | |||
There was a problem hiding this comment.
why not use shouldStripInternal?
There was a problem hiding this comment.
@mhegazy That's what I tried first but to my surprise it did not work; shouldStripInternal returns false!
I found a workaround by scanning the jsDoc elements. But maybe there is fix somewhere else that would make shouldStripInternal return true when the @internal jsdoc comment is present.
There was a problem hiding this comment.
looks like #23611 has a fix for that.
There was a problem hiding this comment.
Yes, that's a better fix. I'm closing this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] There is an associated issue that is labeled
'Bug' or 'help wanted' or is in the Community milestone
[x] Code is up-to-date with the
masterbranch[x] You've successfully run
jake runtestslocally[x] You've signed the CLA
[x] There are new or updated unit tests validating the change
Fixes #23589