Fix duplicate completions bugs #23632
Merged
+44
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
Apr 23, 2018
| @@ -2059,16 +2059,17 @@ namespace ts.Completions { | |||
| const kind = stringToToken(entry.name); | |||
| switch (keywordFilter) { | |||
| case KeywordCompletionFilters.None: | |||
| // "undefined" is a global variable, so don't need a keyword completion for it. | |||
| return kind !== SyntaxKind.UndefinedKeyword; | |||
| // TODO: GH#23631 Includes type keywords because `Array<numb/**/` is treaded as a value location currently. | |||
There was a problem hiding this comment.
isPossiblyTypeArgumentPosition we have this function to check for type argument location
ghost
mentioned this pull request
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23587
Will rebase against master after #23591 is in.
Also removes the "constructor", "get", "set", "private", "public", and "static" contextual keywords from global completions.
(Also removes two tests that are already covered by
completionListKeywords.ts.)