Fix the crash when reporting errors of file that was referenced by inferred project root, is opened right after closing the root file #23636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ferred project root, is opened right after closing the root file Fixes the crash reported in #23255 (comment)
mhegazy
approved these changes
Apr 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the crash reported in #23255 (comment)
Consider the structure through import as:
project root - app
- test -> utilities
When
appis opened followed bytest. The inferred project with project roots asappandtestand the project will containingutilitiesas well.After this operation closing
testand openingutilitieswill mark inferred project as dirty but wont update it. That means, without updating inferred project we would indirectly thinkutilitiesis part of inferred project so no action is needed. And during next update graph is whenutilitieswill be open but not part of any project resulting in exceptions for any semantic/syntactic operations onutilities.With this fix, all projects of info are updated if dirty to ensure correct inferred project assignment or creation