Stop using circularity-unchecked-caching #23808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
reviewed
May 1, 2018
| // @target: es5 | ||
| // @lib: es6 | ||
| // @strict: true | ||
| export interface IValidationError { |
There was a problem hiding this comment.
for lookup speed, can you add the bug number in a comment?
sandersn
approved these changes
May 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #18174 this was changed to a caching call - this is unsafe as contextual typing is reentrant with flow control (which is expected), and
checkExpressionCachedresets the flow loop counter to ensure a consistent cache (preventing the circularity from being detected and correctly handled).Fortunately, the perf issue that precipitated #18174 seems to have been fixed by other perf fixes, making this (potentially erroneous) caching unneeded (the test now executes in under 200ms).
Fixes #23661.