Add noGetErrOnBackgroundUpdate session option to not queue diagnostics check for open files #24298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s check for open files This will ensure that the getErr will be queued in by host and hence would make sure that it is cancellable. Handles one of the scenario delaying completions in #19458
sheetalkamat
force-pushed
the
noErrOnBackgroundUpdate
branch
from
51b65b3 to
f1acbc9
Compare
|
@mjbvz With this PR you can start passing |
|
API changes look good to me. Are you targeting 2.9, or 3.0? |
mhegazy
approved these changes
May 22, 2018
|
@mjbvz It will be in 2.9 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that the getErr will be queued in by host and hence would make sure that it is cancellable.
Handles one of the scenario delaying completions in #19458 wherein the getErr gets scheduled on eg setTypings and the getErr that would be started by tsserver would not be cancellable and hence amid the current ongoing semantic check which could take few seconds depending on file size, tsserver cant even receive the message and hence causing delay in the completion/change processing.