Skip to content

Don't constrain string tag values #24396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2018
Merged

Don't constrain string tag values #24396

merged 1 commit into from
Nov 9, 2018

Conversation

falsandtru
Copy link
Contributor

@mhegazy
Copy link
Contributor

mhegazy commented May 25, 2018

@DanielRosenwasser and @rbuckton can you please review.

@falsandtru
Copy link
Contributor Author

ping @DanielRosenwasser @rbuckton

@RyanCavanaugh
Copy link
Member

@DanielRosenwasser @rbuckton

@seansfkelley seansfkelley mentioned this pull request Sep 5, 2018
Closed
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.2 milestone Sep 17, 2018
@DanielRosenwasser DanielRosenwasser merged commit b48c2b2 into microsoft:master Nov 9, 2018
@DanielRosenwasser
Copy link
Member

Thanks!

@falsandtru falsandtru deleted the lib/Symbol.toStringTag branch November 10, 2018 00:39
@spion spion mentioned this pull request Nov 10, 2018
Merged
@kamilogorek kamilogorek mentioned this pull request Oct 11, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

@rbuckton rbuckton Awaiting requested review from rbuckton

Assignees

@DanielRosenwasser DanielRosenwasser

@rbuckton rbuckton

Labels
None yet
Projects
None yet
Milestone
TypeScript 3.2
Development

Successfully merging this pull request may close these issues.

String Literal types on es6 interfaces for [Symbol.toStringTag]?
5 participants
@falsandtru @mhegazy @RyanCavanaugh @DanielRosenwasser @rbuckton