Skip to content

fix syntax error in unit test #24576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2018
Merged

fix syntax error in unit test #24576

merged 1 commit into from
Jun 4, 2018
+5 −5

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Jun 1, 2018

@mhegazy
Copy link
Contributor

mhegazy commented Jun 4, 2018

So why was not this flagged by the build? are we not building the test file?

@mhegazy
Copy link
Contributor

mhegazy commented Jun 4, 2018

ping @rbuckton

@rbuckton
Copy link
Contributor

rbuckton commented Jun 4, 2018

@mhegazy This is in a template literal and the evaluator doesn't currently report syntax errors.

@mhegazy mhegazy merged commit a14f034 into microsoft:master Jun 4, 2018
@rbuckton rbuckton mentioned this pull request Jun 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajafff @mhegazy @rbuckton