Inspect all possible module paths when looking for the best one to create a specifier with #25850
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,28 +25,3 @@ var Src = /** @class */ (function () { | |
| /// <reference types="dep" /> | ||
| declare class Src implements NS.Dep { | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| //// [tests/cases/compiler/symbolLinkDeclarationEmitModuleNamesImportRef.ts] //// | ||
|
|
||
| //// [index.d.ts] | ||
| export declare const styles: import("styled-components").InterpolationValue[]; | ||
|
|
||
| //// [package.json] | ||
| { | ||
| "name": "styled-components", | ||
| "version": "3.3.3", | ||
| "typings": "typings/styled-components.d.ts" | ||
| } | ||
|
|
||
| //// [styled-components.d.ts] | ||
| export interface InterpolationValue {} | ||
| //// [index.ts] | ||
| import { styles } from "package-a"; | ||
|
|
||
| export function getStyles() { | ||
| return styles; | ||
| } | ||
|
|
||
|
|
||
| //// [index.js] | ||
| "use strict"; | ||
| exports.__esModule = true; | ||
| var package_a_1 = require("package-a"); | ||
| function getStyles() { | ||
| return package_a_1.styles; | ||
| } | ||
| exports.getStyles = getStyles; | ||
|
|
||
|
|
||
| //// [index.d.ts] | ||
| export declare function getStyles(): import("styled-components").InterpolationValue[]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| === tests/cases/compiler/Folder/monorepo/core/index.ts === | ||
| import { styles } from "package-a"; | ||
| >styles : Symbol(styles, Decl(index.ts, 0, 8)) | ||
|
|
||
| export function getStyles() { | ||
| >getStyles : Symbol(getStyles, Decl(index.ts, 0, 35)) | ||
|
|
||
| return styles; | ||
| >styles : Symbol(styles, Decl(index.ts, 0, 8)) | ||
| } | ||
|
|
||
| === tests/cases/compiler/Folder/monorepo/package-a/index.d.ts === | ||
| export declare const styles: import("styled-components").InterpolationValue[]; | ||
| >styles : Symbol(styles, Decl(index.d.ts, 0, 20)) | ||
| >InterpolationValue : Symbol(InterpolationValue, Decl(styled-components.d.ts, 0, 0)) | ||
|
|
||
| === tests/cases/compiler/Folder/node_modules/styled-components/typings/styled-components.d.ts === | ||
| export interface InterpolationValue {} | ||
| >InterpolationValue : Symbol(InterpolationValue, Decl(styled-components.d.ts, 0, 0)) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| === tests/cases/compiler/Folder/monorepo/core/index.ts === | ||
| import { styles } from "package-a"; | ||
| >styles : import("tests/cases/compiler/Folder/node_modules/styled-components/typings/styled-components").InterpolationValue[] | ||
|
|
||
| export function getStyles() { | ||
| >getStyles : () => import("tests/cases/compiler/Folder/node_modules/styled-components/typings/styled-components").InterpolationValue[] | ||
|
|
||
| return styles; | ||
| >styles : import("tests/cases/compiler/Folder/node_modules/styled-components/typings/styled-components").InterpolationValue[] | ||
| } | ||
|
|
||
| === tests/cases/compiler/Folder/monorepo/package-a/index.d.ts === | ||
| export declare const styles: import("styled-components").InterpolationValue[]; | ||
| >styles : import("tests/cases/compiler/Folder/node_modules/styled-components/typings/styled-components").InterpolationValue[] | ||
| >InterpolationValue : import("tests/cases/compiler/Folder/node_modules/styled-components/typings/styled-components").InterpolationValue | ||
|
|
||
| === tests/cases/compiler/Folder/node_modules/styled-components/typings/styled-components.d.ts === | ||
| export interface InterpolationValue {} | ||
| >InterpolationValue : InterpolationValue | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // @declaration: true | ||
| // @useCaseSensitiveFileNames: false | ||
| // @noImplicitReferences: true | ||
| // @filename: Folder/monorepo/package-a/index.d.ts | ||
| export declare const styles: import("styled-components").InterpolationValue[]; | ||
|
|
||
| // @filename: Folder/node_modules/styled-components/package.json | ||
| { | ||
| "name": "styled-components", | ||
| "version": "3.3.3", | ||
| "typings": "typings/styled-components.d.ts" | ||
| } | ||
|
|
||
| // @filename: Folder/node_modules/styled-components/typings/styled-components.d.ts | ||
| export interface InterpolationValue {} | ||
| // @filename: Folder/monorepo/core/index.ts | ||
| import { styles } from "package-a"; | ||
|
|
||
| export function getStyles() { | ||
| return styles; | ||
| } | ||
|
|
||
| // @link: tests/cases/compiler/Folder/node_modules/styled-components -> tests/cases/compiler/Folder/monorepo/package-a/node_modules/styled-components | ||
|
There was a problem hiding this comment. It looks like some tests use There was a problem hiding this comment.
|
||
| // @link: tests/cases/compiler/Folder/monorepo/package-a -> tests/cases/compiler/Folder/monorepo/core/node_modules/package-a | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow all the logic here, but there may be some duplicated effort. A few lines above this we get symlinks, then in
discoverProbableSymlinksthere is some nearly identical (copy-pasted?) code to do the same thing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, it's not duplicated at all. Here we find files whose realpath differed from their actual path, provided those files refer to the imported file. In
discoverProbableSymlinks, we crawl all files looking for common parts among all files with symlinks to find probable directory junction links. If I remember correctly, anyway.