allow BindingPattern in BindingRestElement #26008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
commented
Jul 27, 2018
| @@ -29188,10 +29188,6 @@ namespace ts { | |||
| } | |||
| checkGrammarForDisallowedTrailingComma(elements, Diagnostics.A_rest_parameter_or_binding_pattern_may_not_have_a_trailing_comma); | |||
|
|
|||
| if (node.name.kind === SyntaxKind.ArrayBindingPattern || node.name.kind === SyntaxKind.ObjectBindingPattern) { | |||
There was a problem hiding this comment.
note that this never checked BindingRestProperty because that has a parse error: https://agentcooper.github.io/typescript-play/#code/DYUwLgBA3gdHUF8EQLzQQGmnGBtAusmogNxA
|
@weswigham can you please review |
weswigham
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6275
Downlevel emit already works as expected. Those baselines were not changed.
Just to make sure, here's an example in the playground: https://agentcooper.github.io/typescript-play/?target=1#code/CYUwxgNghgTiAEEQBd7IK4AckC54G0BnZGASwDsBzAGnnPQFsAjEGWpgew6SnIF0A3ACgkqfFFoA6afiZTpAbwAMeMAF8+feAF40WJAKA