🤖 User test baselines have changed #26861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

sandersn merged 1 commit into microsoft:master from typescript-bot:user-update-20180801

Sep 4, 2018

Collaborator

typescript-bot commented Sep 3, 2018

Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc @weswigham @sandersn @RyanCavanaugh


          Update user baselines

b6e1ced

typescript-bot requested review from RyanCavanaugh, sandersn and weswigham

September 3, 2018 13:34

sandersn requested changes

View reviewed changes

Member

sandersn left a comment

Need to file a couple of new bugs. After that I may accept these changes simply because there are a lot of them.

tests/baselines/reference/user/chrome-devtools-frontend.log

               node_modules/chrome-devtools-frontend/front_end/audits2/lighthouse/renderer/details-renderer.js(285,31): error TS2694: Namespace 'DetailsRenderer' has no exported member 'DetailsJSON'.
               node_modules/chrome-devtools-frontend/front_end/audits2/lighthouse/renderer/details-renderer.js(298,8): error TS2339: Property 'DetailsRenderer' does not exist on type 'Window'.
               node_modules/chrome-devtools-frontend/front_end/audits2/lighthouse/renderer/details-renderer.js(303,2): error TS1131: Property or signature expected.
+              node_modules/chrome-devtools-frontend/front_end/audits2/lighthouse/renderer/details-renderer.js(303,8): error TS2300: Duplicate identifier 'type'.

Member

sandersn Sep 4, 2018

It looks like we badly parsed properties as typedefs when there is a line-beginning asterisk in the middle of the type. [1] Now there is a duplicate error marked. Would be fixed completely by #26528

[1]

/** @typedef {{
 * ohno,
 * an,
 * asterisk
 * }}
 */

tests/baselines/reference/user/chrome-devtools-frontend.log

               node_modules/chrome-devtools-frontend/front_end/audits2/lighthouse/renderer/details-renderer.js(344,17): error TS2339: Property 'TableHeaderJSON' does not exist on type 'typeof DetailsRenderer'.
               node_modules/chrome-devtools-frontend/front_end/audits2/lighthouse/renderer/details-renderer.js(348,2): error TS1131: Property or signature expected.
-              node_modules/chrome-devtools-frontend/front_end/audits2/lighthouse/renderer/details-renderer.js(355,17): error TS2300: Duplicate identifier 'NodeDetailsJSON'.

Member

sandersn Sep 4, 2018

These are no longer treated as duplicate declarations because they have the same type.

tests/baselines/reference/user/chrome-devtools-frontend.log

@@ @@ -11,6 +11,7 @@ Standard output: @@
               ../../../../built/local/lib.dom.d.ts(11899,13): error TS2300: Duplicate identifier 'Request'.
               ../../../../built/local/lib.dom.d.ts(16316,11): error TS2300: Duplicate identifier 'Window'.
               ../../../../built/local/lib.dom.d.ts(16447,13): error TS2300: Duplicate identifier 'Window'.
+              ../../../../built/local/lib.dom.d.ts(17190,15): error TS2451: Cannot redeclare block-scoped variable 'name'.

Member

sandersn Sep 4, 2018

Conflict with a typedef property name that we incorrectly parse as a typedef name.

tests/baselines/reference/user/chrome-devtools-frontend.log

               node_modules/chrome-devtools-frontend/front_end/components/DOMBreakpointsSidebarPane.js(243,61): error TS2555: Expected at least 2 arguments, but got 1.
               node_modules/chrome-devtools-frontend/front_end/components/DOMBreakpointsSidebarPane.js(244,63): error TS2555: Expected at least 2 arguments, but got 1.
               node_modules/chrome-devtools-frontend/front_end/components/DOMBreakpointsSidebarPane.js(245,57): error TS2555: Expected at least 2 arguments, but got 1.
-              node_modules/chrome-devtools-frontend/front_end/components/DOMBreakpointsSidebarPane.js(267,52): error TS2694: Namespace 'SDK.DOMDebuggerModel.DOMBreakpoint' has no exported member 'Type'.

Member

sandersn Sep 4, 2018

better binding here too

tests/baselines/reference/user/chrome-devtools-frontend.log

               node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeToolbar.js(302,71): error TS2555: Expected at least 2 arguments, but got 1.
               node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeToolbar.js(303,9): error TS2555: Expected at least 2 arguments, but got 1.
               node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeToolbar.js(305,44): error TS2555: Expected at least 2 arguments, but got 1.
-              node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeToolbar.js(338,5): error TS2322: Type 'ToolbarItem' is not assignable to type '{ item(): any & any; } & { item(): any & any; }'.

Member

sandersn Sep 4, 2018

removed duplicated error. That's nice. Not sure why.

tests/baselines/reference/user/chrome-devtools-frontend.log

               node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeView.js(500,22): error TS2339: Property 'createChild' does not exist on type 'Element'.
               node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeWrapper.js(18,22): error TS2339: Property 'singleton' does not exist on type 'Window'.
               node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeWrapper.js(33,24): error TS2694: Namespace 'Protocol' has no exported member 'Page'.
+              node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeWrapper.js(38,30): error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.

Member

sandersn Sep 4, 2018

this reference to DeviceModeView is borked too. I think it might be a change to the valueDeclaration?

tests/baselines/reference/user/chrome-devtools-frontend.log

-                Property 'ecmaVersion' is incompatible with index signature.
-                  Type 'number' is not assignable to type 'boolean'.
+              node_modules/chrome-devtools-frontend/front_end/formatter_worker/AcornTokenizer.js(14,55): error TS2322: Type 'number' is not assignable to type 'boolean'.
+              node_modules/chrome-devtools-frontend/front_end/formatter_worker/AcornTokenizer.js(14,71): error TS2322: Type 'any[]' is not assignable to type 'boolean'.

Member

sandersn Sep 4, 2018

Per-property errors. That's nice!

tests/baselines/reference/user/chrome-devtools-frontend.log

-                    Type 'any[][]' is not assignable to type '[any, any][]'.
-                      Type 'any[]' is not assignable to type '[any, any]'.
-                        Property '0' is missing in type 'any[]'.
+                Type 'any[]' is not assignable to type '[any, any]'.

Member

sandersn Sep 4, 2018

better tuple elaborations.

tests/baselines/reference/user/chrome-devtools-frontend.log

                 Index signature is missing in type '{}'.
               node_modules/chrome-devtools-frontend/front_end/host/InspectorFrontendHost.js(407,19): error TS2694: Namespace 'Adb' has no exported member 'Config'.
               node_modules/chrome-devtools-frontend/front_end/host/InspectorFrontendHost.js(445,48): error TS2694: Namespace 'InspectorFrontendHostAPI' has no exported member 'ContextMenuDescriptor'.
-              node_modules/chrome-devtools-frontend/front_end/host/InspectorFrontendHost.js(471,12): error TS2538: Type 'string[]' cannot be used as an index type.

Member

sandersn Sep 4, 2018

The removal of this error is still wrong.

tests/baselines/reference/user/chrome-devtools-frontend.log

               node_modules/chrome-devtools-frontend/front_end/text_editor/CodeMirrorTextEditor.js(1261,5): error TS2322: Type 'CodeMirrorPositionHandle' is not assignable to type '{ resolve(): { lineNumber: number; columnNumber: number; }; equal(positionHandle: any): boolean; }'.
               node_modules/chrome-devtools-frontend/front_end/text_editor/CodeMirrorTextEditor.js(1261,5): error TS2322: Type 'CodeMirrorPositionHandle' is not assignable to type '{ resolve(): { lineNumber: number; columnNumber: number; }; equal(positionHandle: any): boolean; }'.
                 Property '_codeMirror' does not exist on type '{ resolve(): { lineNumber: number; columnNumber: number; }; equal(positionHandle: any): boolean; }'.
+              node_modules/chrome-devtools-frontend/front_end/text_editor/CodeMirrorTextEditor.js(1280,21): error TS2339: Property 'autocomplete' does not exist on type 'typeof commands'.

Member

sandersn Sep 4, 2018

Hmm, looks like these are no longer treated as declarations. This despite commands' declaration being CodeMirror.commands = {}.

sandersn mentioned this pull request

In JS, cross-file non-expando assignment declarations are broken #26875

Closed

Member

sandersn commented Sep 4, 2018

Filed #26875 to track the expando assignment bug.
Filed #26877 to track the static vs instance type reference bug.

Member

sandersn commented Sep 4, 2018

I'm going to merge this since there are a lot of diffs and the regressions are tracked by bugs.

sandersn merged commit 0ac3a0a into microsoft:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet