Skip to content

Fix iterated type in for-await-of #27271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2018
Merged

Fix iterated type in for-await-of #27271

merged 1 commit into from
Sep 21, 2018

Conversation

rbuckton
Copy link
Contributor

NOTE: This is the same change in #27247 except this targets "master"

Fixes the type we return in getIteratedTypeOfIterable for for..await..of. and yield* when the expression is an Iterable<Promise<T>>.

Fixes #24570

@rbuckton rbuckton added this to the TypeScript 3.2 milestone Sep 21, 2018
@rbuckton rbuckton mentioned this pull request Sep 21, 2018
Closed
@rbuckton rbuckton merged commit 5fb3976 into master Sep 21, 2018
@rbuckton rbuckton deleted the fix24570-3 branch September 21, 2018 19:28
@jesseschalken jesseschalken mentioned this pull request Nov 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
TypeScript 3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@rbuckton @weswigham