🤖 User test baselines have changed #27546
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
requested changes
Oct 4, 2018
| @@ -108,6 +108,11 @@ node_modules/uglify-js/lib/scope.js(462,15): error TS2554: Expected 0 arguments, | |||
| node_modules/uglify-js/lib/scope.js(487,15): error TS2554: Expected 0 arguments, but got 1. | |||
| node_modules/uglify-js/lib/sourcemap.js(55,25): error TS2304: Cannot find name 'MOZ_SourceMap'. | |||
| node_modules/uglify-js/lib/sourcemap.js(61,23): error TS2304: Cannot find name 'MOZ_SourceMap'. | |||
| node_modules/uglify-js/lib/utils.js(124,27): error TS2339: Property 'v' does not exist on type '{}'. | |||
There was a problem hiding this comment.
#27370 breaks narrowing on constructor functions, eg
/** @constructor */
function AtTop(val) { this.val = val }
/** @type {*} */
var x = 1;
if (x instanceof AtTop) {
x.val
}I don't think this error is correct, but I don't understand how it arises from the change either.
There was a problem hiding this comment.
Fix is up at #27551, so I'll close this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh