-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Add missing case to declaration diagnostic handler #28783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
tests/baselines/reference/declarationEmitLambdaWithMissingTypeParameterNoCrash.errors.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
tests/cases/compiler/declarationEmitLambdaWithMissingTypeParameterNoCrash.ts(2,27): error TS2304: Cannot find name 'T2'. | ||
tests/cases/compiler/declarationEmitLambdaWithMissingTypeParameterNoCrash.ts(2,27): error TS4016: Type parameter 'T1' of exported function has or is using private name 'T2'. | ||
tests/cases/compiler/declarationEmitLambdaWithMissingTypeParameterNoCrash.ts(3,33): error TS2304: Cannot find name 'T2'. | ||
tests/cases/compiler/declarationEmitLambdaWithMissingTypeParameterNoCrash.ts(3,33): error TS4006: Type parameter 'T1' of constructor signature from exported interface has or is using private name 'T2'. | ||
|
||
|
||
==== tests/cases/compiler/declarationEmitLambdaWithMissingTypeParameterNoCrash.ts (4 errors) ==== | ||
export interface Foo { | ||
preFetch: <T1 extends T2> (c: T1) => void; // Type T2 is not defined | ||
~~ | ||
!!! error TS2304: Cannot find name 'T2'. | ||
~~ | ||
!!! error TS4016: Type parameter 'T1' of exported function has or is using private name 'T2'. | ||
preFetcher: new <T1 extends T2> (c: T1) => void; // Type T2 is not defined | ||
~~ | ||
!!! error TS2304: Cannot find name 'T2'. | ||
~~ | ||
!!! error TS4006: Type parameter 'T1' of constructor signature from exported interface has or is using private name 'T2'. | ||
} | ||
|
10 changes: 10 additions & 0 deletions
10
tests/baselines/reference/declarationEmitLambdaWithMissingTypeParameterNoCrash.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
//// [declarationEmitLambdaWithMissingTypeParameterNoCrash.ts] | ||
export interface Foo { | ||
preFetch: <T1 extends T2> (c: T1) => void; // Type T2 is not defined | ||
preFetcher: new <T1 extends T2> (c: T1) => void; // Type T2 is not defined | ||
} | ||
|
||
|
||
//// [declarationEmitLambdaWithMissingTypeParameterNoCrash.js] | ||
"use strict"; | ||
exports.__esModule = true; |
17 changes: 17 additions & 0 deletions
17
tests/baselines/reference/declarationEmitLambdaWithMissingTypeParameterNoCrash.symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
=== tests/cases/compiler/declarationEmitLambdaWithMissingTypeParameterNoCrash.ts === | ||
export interface Foo { | ||
>Foo : Symbol(Foo, Decl(declarationEmitLambdaWithMissingTypeParameterNoCrash.ts, 0, 0)) | ||
|
||
preFetch: <T1 extends T2> (c: T1) => void; // Type T2 is not defined | ||
>preFetch : Symbol(Foo.preFetch, Decl(declarationEmitLambdaWithMissingTypeParameterNoCrash.ts, 0, 22)) | ||
>T1 : Symbol(T1, Decl(declarationEmitLambdaWithMissingTypeParameterNoCrash.ts, 1, 15)) | ||
>c : Symbol(c, Decl(declarationEmitLambdaWithMissingTypeParameterNoCrash.ts, 1, 31)) | ||
>T1 : Symbol(T1, Decl(declarationEmitLambdaWithMissingTypeParameterNoCrash.ts, 1, 15)) | ||
|
||
preFetcher: new <T1 extends T2> (c: T1) => void; // Type T2 is not defined | ||
>preFetcher : Symbol(Foo.preFetcher, Decl(declarationEmitLambdaWithMissingTypeParameterNoCrash.ts, 1, 46)) | ||
>T1 : Symbol(T1, Decl(declarationEmitLambdaWithMissingTypeParameterNoCrash.ts, 2, 21)) | ||
>c : Symbol(c, Decl(declarationEmitLambdaWithMissingTypeParameterNoCrash.ts, 2, 37)) | ||
>T1 : Symbol(T1, Decl(declarationEmitLambdaWithMissingTypeParameterNoCrash.ts, 2, 21)) | ||
} | ||
|
11 changes: 11 additions & 0 deletions
11
tests/baselines/reference/declarationEmitLambdaWithMissingTypeParameterNoCrash.types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
=== tests/cases/compiler/declarationEmitLambdaWithMissingTypeParameterNoCrash.ts === | ||
export interface Foo { | ||
preFetch: <T1 extends T2> (c: T1) => void; // Type T2 is not defined | ||
>preFetch : <T1 extends any>(c: T1) => void | ||
>c : T1 | ||
|
||
preFetcher: new <T1 extends T2> (c: T1) => void; // Type T2 is not defined | ||
>preFetcher : new <T1 extends any>(c: T1) => void | ||
>c : T1 | ||
} | ||
|
5 changes: 5 additions & 0 deletions
5
tests/cases/compiler/declarationEmitLambdaWithMissingTypeParameterNoCrash.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
// @declaration: true | ||
export interface Foo { | ||
preFetch: <T1 extends T2> (c: T1) => void; // Type T2 is not defined | ||
preFetcher: new <T1 extends T2> (c: T1) => void; // Type T2 is not defined | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to add constructor type as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch, probably a good idea, yes!