Unify semantic differences between produceDiagnostics and non-producing checkers #28950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ahejlsberg This is a slightly more nuanced alternative to #28564 that produces fewer changes in most of the baselines. |
|
@weswigham now that #28564's redo is merged, I think this can be closed. Am I right? |
|
Yep, this was an alternative to that which went in the "make services more like command line" direction, rather than the other way around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow them do be able to be used interchangeably for equivalent API results. The core of the change is making it to that we always resolve to an
unknownSignatureon call resolution failure, but also making it possible for the services andgetContextualTypeAPIs to recover data on what the "best" signatures were (without letting the types from those signatures leak into the type heirarchy of the program).The biggest changes are that now when a call has an error quick info shows its return type and arguments as
any, rather than the return type of the "best" signature.