Skip to content

The assert that cached value of config file existance is always correct, might not be true if file watcher is not invoked before creating configured project #29240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

sheetalkamat
Copy link
Member

Fixes #29191

…ct, might not be true if file watcher is not invoked before creating configured project

Fixes #29191
@sheetalkamat sheetalkamat force-pushed the inferredProjectToExternalProject branch from 0132203 to 24cc284 Compare January 2, 2019 23:42
Copy link
Contributor

@uniqueiniquity uniqueiniquity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@sheetalkamat sheetalkamat merged commit b2f76e9 into master Jan 3, 2019
@sheetalkamat sheetalkamat deleted the inferredProjectToExternalProject branch January 3, 2019 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants