Skip to content

There is no need to check for file presence when trying to rename imports based on file rename #29313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Jan 8, 2019

Fixes #29031
The perf changed from about 5.7s to 426ms

Info 1889 [15:23:1.527] request:
    {"seq":33,"type":"request","command":"getEditsForFileRename","arguments":{"file":"c:/github/vscode/src/vs/base/common/newPaging.ts","oldFilePath":"c:/github/vscode/src/vs/base/common/paging.ts","newFilePath":"c:/github/vscode/src/vs/base/common/newPaging.ts"}}
Perf 1890 [15:23:1.954] 33::getEditsForFileRename: elapsed time (in milliseconds) 426.4376

@sheetalkamat sheetalkamat merged commit 4c70bf0 into master Jan 9, 2019
@sheetalkamat sheetalkamat deleted the getEditsForRename branch January 9, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants