Skip to content

Fix crash on decorated field with negative literal type #29333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/compiler/transformers/ts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1898,6 +1898,7 @@ namespace ts {
case SyntaxKind.StringLiteral:
return createIdentifier("String");

case SyntaxKind.PrefixUnaryExpression:
case SyntaxKind.NumericLiteral:
return createIdentifier("Number");

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
//// [decoratorWithNegativeLiteralTypeNoCrash.ts]
class A {
@decorator
public field1: -1 = -1;
}
function decorator(target: any, field: any) {}

//// [decoratorWithNegativeLiteralTypeNoCrash.js]
var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
var __metadata = (this && this.__metadata) || function (k, v) {
if (typeof Reflect === "object" && typeof Reflect.metadata === "function") return Reflect.metadata(k, v);
};
var A = /** @class */ (function () {
function A() {
this.field1 = -1;
}
__decorate([
decorator,
__metadata("design:type", Number)
], A.prototype, "field1", void 0);
return A;
}());
function decorator(target, field) { }
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
=== tests/cases/compiler/decoratorWithNegativeLiteralTypeNoCrash.ts ===
class A {
>A : Symbol(A, Decl(decoratorWithNegativeLiteralTypeNoCrash.ts, 0, 0))

@decorator
>decorator : Symbol(decorator, Decl(decoratorWithNegativeLiteralTypeNoCrash.ts, 3, 1))

public field1: -1 = -1;
>field1 : Symbol(A.field1, Decl(decoratorWithNegativeLiteralTypeNoCrash.ts, 0, 9))
}
function decorator(target: any, field: any) {}
>decorator : Symbol(decorator, Decl(decoratorWithNegativeLiteralTypeNoCrash.ts, 3, 1))
>target : Symbol(target, Decl(decoratorWithNegativeLiteralTypeNoCrash.ts, 4, 19))
>field : Symbol(field, Decl(decoratorWithNegativeLiteralTypeNoCrash.ts, 4, 31))

Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
=== tests/cases/compiler/decoratorWithNegativeLiteralTypeNoCrash.ts ===
class A {
>A : A

@decorator
>decorator : (target: any, field: any) => void

public field1: -1 = -1;
>field1 : -1
>-1 : -1
>1 : 1
>-1 : -1
>1 : 1
}
function decorator(target: any, field: any) {}
>decorator : (target: any, field: any) => void
>target : any
>field : any

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// @target: es5
// @experimentalDecorators: true
// @emitDecoratorMetadata: true
class A {
@decorator
public field1: -1 = -1;
}
function decorator(target: any, field: any) {}