Type narrowing by construct signature of interface or object type literal #2969
Conversation
| if (constructorSignitures) { | ||
| let constructorType = getUnionType(map(constructorSignitures, constructorSignature => { | ||
| if (constructorSignature.typeParameters && constructorSignature.typeParameters.length !== 0) { | ||
| // TODO convert type parameters to any or empty object types. e.g. Sample<T> -> Sample<any> or Sample<{}>. |
There was a problem hiding this comment.
I can't found way to instantiate type parameters. e.g. B<T> to B<any>.
the way is not exists?
|
@mhegazy thank you for your advice! |
|
👍 |
| if (isTypeSubtypeOf(targetType, type)) { | ||
| return targetType; | ||
| // Target type is type of constructor signiture | ||
| let constructSignitures: Signature[]; |
There was a problem hiding this comment.
constructSignitures -> constructSignatures
|
@DanielRosenwasser thank you for your comment! |
| } | ||
| // If the current type is a union type, remove all constituents that aren't subtypes of the target. | ||
| if (type.flags & TypeFlags.Union) { | ||
| return getUnionTypeOfSubtypeConstituents(<UnionType>type, targetType); |
There was a problem hiding this comment.
I'm not a huge fan of this name. I've talked it over with @mhegazy and @DanielRosenwasser, and it's probably better to keep this line as it was, instead of factoring it out.
|
@DanielRosenwasser Thank you very much to me to corrections of my English. |
vvakame
changed the title
vvakame
changed the title
vvakame
force-pushed
the
typeguardsByConstructorSigniture
branch
from
2d51618 to
f5bcbbc
Compare
vvakame
force-pushed
the
typeguardsByConstructorSigniture
branch
from
f5bcbbc to
776f390
Compare
|
wow, travis ci failed... |
|
@vvakame i ran into that yesterday. i think it is related to a change @JsonFreeman did, not sure if what you are seeing is correct the behavior or not. |
|
@vvakame where are you seeing test failures? Right now Travis is saying that the tests are passing. |
|
@mhegazy @DanielRosenwasser https://travis-ci.org/Microsoft/TypeScript/builds/61452430 this is it. |
|
👍 |
|
Thanks! |
|
yay! 😸 Thanks for a lot of supports! |
implement #1283