Fix #28798: Treat primitive key types as empty when relating to indexer from generic mapped type. #29699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-williams
changed the title
|
Will fix conflicts this week. |
jack-williams
force-pushed
the
generic-mapped-typed-indexer-fix
branch
from
c770aac to
eda60d8
Compare
|
@ahejlsberg Closing the PR as you have fixed this in #30769 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28798
When relating source type
Tto a target type{ [P in U]: X }, the GLB ofkeyof Tmust contain the LUB ofU. The typesstringandnumberguarantee no keys so the GLB is the empty set, hence why they are filtered out.1. I should probably get rid of the symbol flag in the filter function.2. I'm not sure this fix generalises to arbitrary index signatures; maybe we should hold off on this until that is merged.