Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocha updated and no longer ships a
ms
implementation itself, instead it uses thems
package. Now we do in our mocha output, too. In addition, it now only sets up the hooks for generate a.stats
object in its.run
method (which we don't call, as it sets up a bunch of things we don't need or want), so we need to initialize stats generation ourselves.Seems like Remove diagnostic dependent output in
structuredTypeRelatedTo
#29817 was opened during the period where we weren't self-testing on CI 😢 This fixes the new strict function type errors identified inwatchUtilities
by that change (which previously went silently unheard due to the structural fallback & diagnostic-mode dependence of the check!).