Add more information in case of incompatible constructor signature #2… #30371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@DanielRosenwasser can you or maybe someone else check this pr? Or it will be check as soon as the turn comes? |
| @@ -2601,6 +2601,10 @@ | |||
| "category": "Error", | |||
| "code": 2753 | |||
| }, | |||
| "Types of constructor signature are incompatible.": { | |||
| "category": "Error", | |||
There was a problem hiding this comment.
Please indent the inner properties like the rest of the file
|
@amaksimovich2 overall looks good. Can you resolve the merge conflict and add the repro from #31046 as well? Thanks! |
|
This PR hasn't seen any activity for quite a while, so I'm going to close it to keep the number of open PRs manageable. Feel free to open a fresh PR or continue the discussion here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21253 This is my first pull request to TypeScript, so I will free for your comments. At first I tried to implement code from pr of previous contributors, but one test "errorsWithInvokablesInUnions01" failed. So I investigated a problem and added new check on source/target objectFlag comparison. Actually I still not
so good familiar with TS logic, so maybe it's wrong way. If it's true, give me feedback, please.