Skip to content

Fix type parameter inference cache invalidation logic #32362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Conversation

ahejlsberg
Copy link
Member

Fixes #32230.

@ahejlsberg
Copy link
Member Author

@typescript-bot run dt
@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 11, 2019

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 4b9ca33. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 11, 2019

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 4b9ca33. You can monitor the build here. It should now contribute to this PR's status checks.

@ahejlsberg
Copy link
Member Author

No changes in RWC baselines compared to master (all errors are preexisting conditions).

@ahejlsberg
Copy link
Member Author

Errors in DT test runs are unrelated to this PR.

@ahejlsberg ahejlsberg requested a review from RyanCavanaugh July 12, 2019 17:47
@ahejlsberg ahejlsberg added this to the TypeScript 3.6.0 milestone Jul 12, 2019
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good - any non-fixed inferredType was potentially generated with other non-fixed types, so when we fix or update one, we should refresh them all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic inference different between equivalent function expression and shorthand method in object literal
4 participants