Implement declaration emit for accessors in the js declaration emitter #33649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
approved these changes
Sep 27, 2019
| export class F { | ||
| set x(arg: number); | ||
| get x(): number; | ||
| } |
| @@ -5750,7 +5766,40 @@ namespace ts { | |||
| const staticFlag = isStatic ? ModifierFlags.Static : 0; | |||
| const rawName = unescapeLeadingUnderscores(p.escapedName); | |||
| const name = getPropertyNameNodeForSymbolFromNameType(p, context) || createIdentifier(rawName); | |||
| if (p.flags & (SymbolFlags.Property | SymbolFlags.Accessor | SymbolFlags.Variable)) { | |||
| const firstPropertyLikeDecl = find(p.declarations, d => isPropertyDeclaration(d) || isAccessor(d) || isVariableDeclaration(d) || isPropertySignature(d) || isBinaryExpression(d) || isPropertyAccessExpression(d)); | |||
There was a problem hiding this comment.
Suggested change
| const firstPropertyLikeDecl = find(p.declarations, d => isPropertyDeclaration(d) || isAccessor(d) || isVariableDeclaration(d) || isPropertySignature(d) || isBinaryExpression(d) || isPropertyAccessExpression(d)); | |
| const firstPropertyLikeDecl = find(p.declarations, or(isPropertyDeclaration, isAccessor, isVariableDeclaration, isPropertySignature, isBinaryExpression, isPropertyAccessExpression)); |
unless you need narrowing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also changed how
Object.definePropertybinds symbols a little bit. It now includes theSetAccessorandGetAccessorsymbol flags for define property calls that define setters and/or getters, like one may expect.Fixes #33643