-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Adds a failing test for System JS compilation. #3376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
//// [systemModuleEnum.ts] | ||
|
||
export enum Foo {} | ||
|
||
export module Bar { | ||
export var baz = (): any => {} | ||
} | ||
|
||
|
||
//// [systemModuleEnum.js] | ||
System.register([], function(exports_1) { | ||
var Foo, Bar; | ||
return { | ||
setters:[], | ||
execute: function() { | ||
(function (Foo) { | ||
})(Foo || (Foo = {})); | ||
exports_1("Foo", Foo); | ||
(function (Bar) { | ||
Bar.baz = function () { }; | ||
})(Bar = Bar || (Bar = {})); | ||
exports_1("Bar", Bar); | ||
} | ||
} | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
=== tests/cases/compiler/systemModuleEnum.ts === | ||
|
||
export enum Foo {} | ||
>Foo : Symbol(Foo, Decl(systemModuleEnum.ts, 0, 0)) | ||
|
||
export module Bar { | ||
>Bar : Symbol(Bar, Decl(systemModuleEnum.ts, 1, 18)) | ||
|
||
export var baz = (): any => {} | ||
>baz : Symbol(baz, Decl(systemModuleEnum.ts, 4, 11)) | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
=== tests/cases/compiler/systemModuleEnum.ts === | ||
|
||
export enum Foo {} | ||
>Foo : Foo | ||
|
||
export module Bar { | ||
>Bar : typeof Bar | ||
|
||
export var baz = (): any => {} | ||
>baz : () => any | ||
>(): any => {} : () => any | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
// @module: system | ||
|
||
export enum Foo {} | ||
|
||
export module Bar { | ||
export var baz = (): any => {} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compiler does not generate a semicolon at the end of this line, however it appears to be necessary. I am guessing that the JS runtime is seeing an attempt to call a function on
exports_1("Foo", Foo)(...)
, since the following function is wrapped in parenthesis. The semicolon tells the runtime that a new expression is starting on line 19.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right JS treats it as call statement. I think you can just add a semicolon to this line and you can submit a fix 👍
https://github.com/Microsoft/TypeScript/blob/master/src/compiler/emitter.ts#L4506