Skip to content

Fix type inference regression #34607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2019
Merged

Fix type inference regression #34607

merged 3 commits into from
Oct 21, 2019

Conversation

ahejlsberg
Copy link
Member

Fixes #33490.

@ahejlsberg ahejlsberg added this to the TypeScript 3.7.1 milestone Oct 21, 2019
@ahejlsberg
Copy link
Member Author

@typescript-bot test this
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 21, 2019

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 82019d6. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 21, 2019

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 82019d6. You can monitor the build here. It should now contribute to this PR's status checks.

@ahejlsberg
Copy link
Member Author

The RWC tests are clean and the DT test failures are pre-existing conditions. So, looks good.

@ahejlsberg ahejlsberg merged commit f84fd30 into master Oct 21, 2019
@ahejlsberg ahejlsberg deleted the fix33490 branch October 21, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression for inferred unions in generic parameters
3 participants