Don't npm install the parent project with no args #35359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jablko
force-pushed
the
patch-30
branch
2 times, most recently
from
b4e13b6 to
f2540d3
Compare
jablko
force-pushed
the
patch-30
branch
3 times, most recently
from
fd9652c to
34c331e
Compare
jablko
force-pushed
the
patch-30
branch
4 times, most recently
from
03dbecc to
0959df8
Compare
jablko
force-pushed
the
patch-30
branch
2 times, most recently
from
bb96781 to
78ade52
Compare
sandersn
requested changes
Feb 11, 2020
| @@ -78,7 +78,7 @@ namespace Harness { | |||
| exec("npm", ["i", "--ignore-scripts"], { cwd, timeout: timeout / 2 }); // NPM shouldn't take the entire timeout - if it takes a long time, it should be terminated and we should log the failure | |||
| } | |||
| const args = [path.join(IO.getWorkspaceRoot(), "built/local/tsc.js")]; | |||
| if (types) { | |||
| if (types?.length) { | |||
| args.push("--types", types.join(",")); | |||
There was a problem hiding this comment.
this is not correct; args needs to include --types even if the list is empty. npm install is OK to skip though.
I think this will make the diffs in the baselines go away, unfortunately. The real fix for those projects is to add types entries to their tsconfigs.
sandersn
approved these changes
Feb 12, 2020
| @@ -1,4 +1,4 @@ | |||
| { | |||
| "cloneUrl": "https://github.com/Microsoft/TypeScript-React-Starter", | |||
| "cloneUrl": "https://github.com/Microsoft/TypeScript-WeChat-Starter.git", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.