🤖 User test baselines have changed for refs/heads/master #36765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
force-pushed
the
user-update-Microsoft-20200104-refs/heads/master
branch
from
a436b9a to
7b40782
Compare
Closed
typescript-bot
force-pushed
the
user-update-Microsoft-20200104-refs/heads/master
branch
2 times, most recently
from
adb1214 to
494445d
Compare
typescript-bot
force-pushed
the
user-update-Microsoft-20200104-refs/heads/master
branch
from
494445d to
08e19b2
Compare
sandersn
approved these changes
Feb 13, 2020
| [XX:XX:XX] Error: /vscode/src/vs/workbench/contrib/remote/browser/remote.ts(652,8): Parameter 'choice' implicitly has an 'any' type. | ||
| [XX:XX:XX] Error: /vscode/src/vs/workbench/contrib/remote/browser/remote.ts(637,8): Parameter 'choice' implicitly has an 'any' type. | ||
| [XX:XX:XX] Error: /vscode/src/vs/workbench/contrib/remote/browser/remote.ts(652,8): Parameter 'choice' implicitly has an 'any' type. | ||
| [XX:XX:XX] Error: /vscode/extensions/typescript-language-features/src/typescriptServiceClient.ts(735,37): 'command' is specified more than once, so this usage will be overwritten. |
There was a problem hiding this comment.
{ command, ...(error instanceof TypeScriptServerError ? error.telemetry : {}) }
seems like this shouldn't be an error since the righthand type should be typeof error.telemetry | {} ↠ {}
There was a problem hiding this comment.
oh, it's because it checks each union member separately, and the union doesn't undergo subtype reduction anymore.
| @@ -232,6 +232,7 @@ node_modules/lodash/core.js(1566,57): error TS2554: Expected 1 arguments, but go | |||
| node_modules/lodash/core.js(1709,41): error TS2532: Object is possibly 'undefined'. | |||
| node_modules/lodash/core.js(1745,18): error TS2348: Value of type 'typeof lodash' is not callable. Did you mean to include 'new'? | |||
| node_modules/lodash/core.js(2183,41): error TS8024: JSDoc '@param' tag has name 'iteratees', but there is no parameter with that name. | |||
| node_modules/lodash/core.js(2473,21): error TS1345: An expression of type 'void' cannot be tested for truthiness | |||
There was a problem hiding this comment.
This error is correct. Looking to see whether it's new...
Yes: 08e6bc2
| @@ -168,6 +307,9 @@ office-ui-fabric-react: ~~~~~~~~~~~~~~~~~ | |||
| office-ui-fabric-react: src/components/Calendar/CalendarYear.tsx:5:31 - error TS2307: Cannot find module './Calendar.scss'. | |||
| office-ui-fabric-react: 5 import * as stylesImport from './Calendar.scss'; | |||
| office-ui-fabric-react: ~~~~~~~~~~~~~~~~~ | |||
| office-ui-fabric-react: src/components/ChoiceGroup/ChoiceGroup.base.tsx:130:19 - error TS2783: 'key' is specified more than once, so this usage will be overwritten. | |||
| @@ -177,6 +319,9 @@ office-ui-fabric-react: ~~~~~~~~~~~~~~~~~~~~~~~ | |||
| office-ui-fabric-react: src/components/ContextualMenu/examples/ContextualMenu.Icon.Example.tsx:12:31 - error TS2307: Cannot find module './ContextualMenuExample.scss'. | |||
| office-ui-fabric-react: 12 import * as stylesImport from './ContextualMenuExample.scss'; | |||
| office-ui-fabric-react: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| office-ui-fabric-react: src/components/DetailsList/DetailsList.base.tsx:479:19 - error TS2783: 'selection' is specified more than once, so this usage will be overwritten. | |||
| office-ui-fabric-react: 479 selection={selection} | |||
| @@ -106,6 +106,8 @@ node_modules/npm/lib/config.js(84,19): error TS2339: Property 'config' does not | |||
| node_modules/npm/lib/config.js(85,15): error TS2339: Property 'config' does not exist on type 'typeof EventEmitter'. | |||
| node_modules/npm/lib/config.js(87,7): error TS2339: Property 'config' does not exist on type 'typeof EventEmitter'. | |||
| node_modules/npm/lib/config.js(93,25): error TS2339: Property 'config' does not exist on type 'typeof EventEmitter'. | |||
| node_modules/npm/lib/config.js(118,31): error TS2345: Argument of type '(er: any) => any' is not assignable to parameter of type 'string | number | Options | undefined'. | |||
There was a problem hiding this comment.
type resolution was wrong before and was resolving to the mkdirp types in the typescript repo root.
| node_modules/chrome-devtools-frontend/front_end/bindings/CSSWorkspaceBinding.js(204,16): error TS2339: Property '_header' does not exist on type 'V'. | ||
| node_modules/chrome-devtools-frontend/front_end/bindings/CSSWorkspaceBinding.js(205,27): error TS2345: Argument of type 'CSSStyleSheetHeader' is not assignable to parameter of type 'K'. | ||
| 'CSSStyleSheetHeader' is assignable to the constraint of type 'K', but 'K' could be instantiated with a different subtype of constraint '{}'. | ||
| node_modules/chrome-devtools-frontend/front_end/bindings/CSSWorkspaceBinding.js(206,16): error TS2339: Property 'update' does not exist on type 'V'. | ||
| node_modules/chrome-devtools-frontend/front_end/bindings/CSSWorkspaceBinding.js(216,46): error TS2345: Argument of type 'CSSStyleSheetHeader' is not assignable to parameter of type 'K'. | ||
| 'CSSStyleSheetHeader' is assignable to the constraint of type 'K', but 'K' could be instantiated with a different subtype of constraint '{}'. | ||
| node_modules/chrome-devtools-frontend/front_end/bindings/CSSWorkspaceBinding.js(217,16): error TS2339: Property '_header' does not exist on type 'V'. |
There was a problem hiding this comment.
this is an existing bug with chrome's multimap types but it is happening a lot more now. Not sure why.
There was a problem hiding this comment.
ah--previously they would be reported once in a call and downstream calls would have any. Now the escaped K and V type parameters propogate around a lot more.
| @@ -3768,10 +3778,6 @@ node_modules/chrome-devtools-frontend/front_end/components/Linkifier.js(504,31): | |||
| node_modules/chrome-devtools-frontend/front_end/components/Linkifier.js(505,28): error TS2339: Property '_linkHandlerSettingInstance' does not exist on type 'typeof Linkifier'. | |||
| node_modules/chrome-devtools-frontend/front_end/components/Linkifier.js(506,67): error TS2555: Expected at least 2 arguments, but got 1. | |||
| node_modules/chrome-devtools-frontend/front_end/components/Linkifier.js(508,33): error TS2339: Property '_linkHandlerSettingInstance' does not exist on type 'typeof Linkifier'. | |||
| node_modules/chrome-devtools-frontend/front_end/components/Linkifier.js(564,9): error TS2322: Type '({ section: string; title: any; handler: () => void; } | { section: string; title: string; handler: any; })[]' is not assignable to type '{ title: string; handler: () => any; }[]'. | |||
There was a problem hiding this comment.
auto types should never have applied here, but I'm not sure why they no longer do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript