Skip to content

Set correct pos for NamespaceExport #36794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2020

Conversation

andrewbranch
Copy link
Member

Fixes #36762

Baseline changes verify this works, but the output of a simple script is easier to look at:

ExportDeclaration (0, 27) 'export * as ns from "test";'
  NamespaceExport (6, 14) ' * as ns'
    Identifier (11, 14) ' ns'
  StringLiteral (19, 26) ' "test"'
EndOfFileToken (27, 27) ''

Copy link
Contributor

@Kingwl Kingwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault, thanks

@andrewbranch andrewbranch merged commit b1e706d into microsoft:master Feb 14, 2020
@andrewbranch andrewbranch deleted the bug/36762 branch February 14, 2020 20:45
andrewbranch added a commit to andrewbranch/TypeScript that referenced this pull request Feb 14, 2020
* Set correct pos for NamespaceExport

* Update tests
DanielRosenwasser pushed a commit that referenced this pull request Feb 14, 2020
* Fix renaming an ExportSpecifier name when propertyName is present (#36790)

* Fix renaming exportSpecifier name when propertyName is present

* Add baseline test for name without propertyName too

* Set correct pos for NamespaceExport (#36794)

* Set correct pos for NamespaceExport

* Update tests
andrewbranch added a commit that referenced this pull request Feb 28, 2020
* Fix renaming an ExportSpecifier name when propertyName is present (#36790)

* Fix renaming exportSpecifier name when propertyName is present

* Add baseline test for name without propertyName too

* Set correct pos for NamespaceExport (#36794)

* Set correct pos for NamespaceExport

* Update tests

* Cherry-pick PR #37064 into release-3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NamespaceExport node has inconsistent width
6 participants