Revert "Revert "Support declaration emit for late bound element acces…

[weswigham]

…ses assigned to functions in both TS and JS (#36593)" (#37034)"

This reverts commit 4d5464e.

Fixes #33569

[weswigham]

@typescript-bot user test this so I can keep around a log of the enhanced-resolve failure until I isolate the issue.

[typescript-bot]

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at a24659d. You can monitor the build here.

[typescript-bot]

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

[sandersn]

@weswigham is this meant for merging? Or is it waiting for additional fixes after you figure out the enhanced-resolve failure?

[weswigham]

Waiting for an additional fix~

[sandersn]

What is the additional fix?

[weswigham]

Mmmmm, sorry, I haven't gotten back to it yet; but I'm pretty sure I need to rethink how the cjs merge/late bound exports/normally bound exports merge sequence happens in its entirety. What this change does right now is ultimately a kind of hack; but the reason I tried that is because the alternative is essentially scrapping the current "cjs module symbol merge" model in the checker. It's not great, but I didn't really want to undertake redoing it to better integrate with normal symbol member resolution if I could help it. The enhanced-resolve break just proved that this hack wasn't robust enough for the real world, so the more complete work (to make it so "cjsy" exports are looked up either by normal export or late bound export resolution without overwriting the symbol) is required, probably.

[sandersn]

This PR hasn't seen any activity for quite a while, so I'm going to close it to keep the number of open PRs manageable. Feel free to open a fresh PR or continue the discussion here.