More precise property-overwritten-by-spread errors #37192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to do this check in getSpreadType just doesn't have enough information, so I moved it to checkObjectLiteral, which is a better place for issuing errors anyway. Unfortunately, the approach is kind of expensive in that it 1. creates a new map for each property and 2. iterates over all properties of the spread type, even if it's a union. I have some ideas to improve (1) that might work out. I'm not sure how bad (2) is since we're going to iterate over all properties of all constituents of a union. Fixes #36779
weswigham
approved these changes
Mar 3, 2020
src/compiler/checker.ts
Outdated
| @@ -22560,6 +22548,7 @@ namespace ts { | |||
| let patternWithComputedProperties = false; | |||
| let hasComputedStringProperty = false; | |||
| let hasComputedNumberProperty = false; | |||
| const propertyDeclarations = createMap<Symbol>(); | |||
There was a problem hiding this comment.
createSymbolTable or createUnderscoreEscapedMap tbh
|
@typescript-bot perf test this |
|
Heya @sandersn, I've started to run the perf test suite on this PR at 35bbfdc. You can monitor the build here. Update: The results are in! |
|
@sandersn Here they are:Comparison Report - master..37192
System
Hosts
Scenarios
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Perf seems OK as-is, so I'm going to skip any fanciness and just change the name and constructor of (I was going to try to spill from propertiesTable to propertyDeclarations, not creating propertyDeclarations in object literals with no spreads. Fancy, but takes more code and harder to read.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to do this check in getSpreadType just doesn't have enough information, so I moved it to checkObjectLiteral, which is a better place for issuing errors anyway.
Unfortunately, the approach is kind of expensive in that it
I have some ideas to improve (1) that might work out. I'm not sure how bad (2) is since we're going to iterate over all properties of all
constituents of a union.
Fixes #36779