Skip to content

fix broken regex on "src/services/completions.ts#getCompletionData" #37546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 11, 2020
Merged

fix broken regex on "src/services/completions.ts#getCompletionData" #37546

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ece9f34
fix broken regex on src/services/completions.ts#840
jeffy-g Mar 30, 2020
ff454d5
update forslash test
jeffy-g Apr 1, 2020
6ad12e0
regex
jeffy-g Apr 2, 2020
3336102
fourslash test (Temporary code
jeffy-g Apr 4, 2020
c4108f2
regex: more restrictive in terms of jsdoc format
jeffy-g Apr 10, 2020
ada017e
regex: max indent restriction
jeffy-g Apr 10, 2020
92ac5cb
achieved goal by partial match strategy (probably
jeffy-g Apr 11, 2020
8c58df3
cleanup
jeffy-g Apr 11, 2020
fe460f0
apply requested changes
jeffy-g Apr 29, 2020
3f1bb2d
Change to a version with minimal modifications
jeffy-g May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/completions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ namespace ts.Completions {
// * |c|
// */
const lineStart = getLineStartPositionForPosition(position, sourceFile);
if (!(sourceFile.text.substring(lineStart, position).match(/[^\*|\s|(/\*\*)]/))) {
if (!/[^\*|\s(/)]/.test(sourceFile.text.substring(lineStart, position))) {
return { kind: CompletionDataKind.JsDocTag };
}
}
Expand Down