Fix issue https://github.com/Microsoft/TypeScript/issues/3277 #3780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ShyykoSerhiy, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
@ShyykoSerhiy, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
| @@ -282,11 +282,16 @@ namespace ts { | |||
| }; | |||
|
|
|||
| function fileChanged(curr: any, prev: any) { | |||
| // mtime.getTime() equals 0 if file was removed | |||
| if (curr.mtime.getTime() === 0) { | |||
| callback(fileName, true); | |||
There was a problem hiding this comment.
Add comment with parameter name in front of boolean arguments (e.g. callback(fileName, /* removed */ true);
|
@ShyykoSerhiy can you refresh and resubmit? |
|
👍 |
|
Sorry for the delay. merged manually. |
zhengbli
added a commit
to zhengbli/TypeScript
that referenced
this pull request
Oct 5, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3277.