Port PR 3689 into release 1.5 #3797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -242,6 +245,12 @@ module ts { | |||
| return createTextChangeRange( | |||
| createTextSpan(decoded.span.start, decoded.span.length), decoded.newLength); | |||
| } | |||
|
|
|||
| public dispose(): void { | |||
| if ("dispose" in this.scriptSnapshotShim) { | |||
There was a problem hiding this comment.
Why do this instead of the property check in services.ts?
There was a problem hiding this comment.
Can you even do a property check on a COM object?
There was a problem hiding this comment.
If this is a problem with COM objects, let's leave a comment explaining it.
There was a problem hiding this comment.
property check here will effectively become method call with no arguments
|
👍 |
|
we need to merge this into master. |
|
I can merge it. |
|
Done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.