Skip to content

[Cherry-pick] Properly handle private/protected members in unions of object types (… #38334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2020

Conversation

DanielRosenwasser
Copy link
Member

Cherry-picks #38277 into release-3.9

Fixes #38236 for 3.9.2

…38277)

* Property handle private/protected properties in unions of object types

* Add regression test
@DanielRosenwasser
Copy link
Member Author

@ahejlsberg @sandersn this wasn't a simple cherry-pick and it's 3.9.2-bound, so I want to make sure I get some eyes on it.

@DanielRosenwasser
Copy link
Member Author

@typescript-bot user test this
@typescript-bot test this
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 7, 2020

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at f4d69b9. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Heya @DanielRosenwasser, I'm starting to run the extended test suite on this PR at f4d69b9. Hold tight - I'll update this comment with the log link once the build has been queued.

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 7, 2020

Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at f4d69b9. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@DanielRosenwasser DanielRosenwasser merged commit b7d3459 into release-3.9 May 7, 2020
@DanielRosenwasser DanielRosenwasser deleted the cherry-pick-fix38236 branch May 7, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants